refactor: remove shards from by-name

This commit is contained in:
Youwen Wu 2024-10-20 01:51:46 -07:00
parent 588a1dc5a9
commit c6f1cdeb0f
Signed by: youwen5
GPG key ID: 865658ED1FE61EC3
4 changed files with 55 additions and 6 deletions

View file

@ -66,7 +66,10 @@
# }; # };
# digression-linear-algebra = alexandriaLib.callTypstProject (import ./documents/by-name/digression-linear-algebra/package.nix); # digression-linear-algebra = alexandriaLib.callTypstProject (import ./documents/by-name/digression-linear-algebra/package.nix);
# }; # };
legacyPackages = alexandriaLib.parsePkgs ./documents; legacyPackages = (
(alexandriaLib.indexByName ./documents/by-name)
// (alexandriaLib.indexByCourse ./documents/by-course)
);
# apps = rec { # apps = rec {
# default = watch; # default = watch;
# build = flake-utils.lib.mkApp { # build = flake-utils.lib.mkApp {

View file

@ -16,5 +16,8 @@ rec {
inherit cleanTypstSource; inherit cleanTypstSource;
} }
); );
parsePkgs = (import ./parsePkgs.nix) (defaultArgs // { inherit callTypstProject; }); indexByName = (import ./indexByName.nix) (defaultArgs // { inherit callTypstProject; });
indexByCourse = (import ./indexByCourse.nix) (
defaultArgs // { inherit callTypstProject indexByName; }
);
} }

View file

@ -0,0 +1,42 @@
{
pkgs,
callTypstProject,
indexByName,
...
}:
baseDirectory:
let
inherit (pkgs) lib;
inherit (lib.attrsets)
mapAttrs
mapAttrsToList
mergeAttrsList
;
inherit (builtins) readDir;
in
let
# Package files for a single shard
# Type: String -> String -> AttrsOf Path
namesForShard =
shard: type:
if type != "directory" then
# Ignore all non-directories. Technically only README.md is allowed as a file in the base directory, so we could alternatively:
# - Assume that README.md is the only file and change the condition to `shard == "README.md"` for a minor performance improvement.
# This would however cause very poor error messages if there's other files.
# - Ensure that README.md is the only file, throwing a better error message if that's not the case.
# However this would make for a poor code architecture, because one type of error would have to be duplicated in the validity checks and here.
# Additionally in either of those alternatives, we would have to duplicate the hardcoding of "README.md"
{ }
else
# mapAttrs (name: _: baseDirectory + "/${shard}/${name}/package.nix") (
# readDir (baseDirectory + "/${shard}")
# );
mapAttrs (a: b: indexByName (baseDirectory + "/${a}")) (readDir baseDirectory);
in
# mapAttrs (a: b: builtins.trace (builtins.tryEval a) b) (
# mergeAttrsList (mapAttrsToList namesForShard (readDir baseDirectory))
# )
mapAttrs (a: b: (callTypstProject (import (/. + b)))) (
mergeAttrsList (mapAttrsToList namesForShard (readDir baseDirectory))
)

View file

@ -13,7 +13,7 @@ let
# Package files for a single shard # Package files for a single shard
# Type: String -> String -> AttrsOf Path # Type: String -> String -> AttrsOf Path
namesForShard = namesForShard =
shard: type: name: type:
if type != "directory" then if type != "directory" then
# Ignore all non-directories. Technically only README.md is allowed as a file in the base directory, so we could alternatively: # Ignore all non-directories. Technically only README.md is allowed as a file in the base directory, so we could alternatively:
# - Assume that README.md is the only file and change the condition to `shard == "README.md"` for a minor performance improvement. # - Assume that README.md is the only file and change the condition to `shard == "README.md"` for a minor performance improvement.
@ -23,9 +23,10 @@ let
# Additionally in either of those alternatives, we would have to duplicate the hardcoding of "README.md" # Additionally in either of those alternatives, we would have to duplicate the hardcoding of "README.md"
{ } { }
else else
mapAttrs (name: _: baseDirectory + "/${shard}/${name}/package.nix") ( # mapAttrs (name: _: baseDirectory + "/${shard}/${name}/package.nix") (
readDir (baseDirectory + "/${shard}") # readDir (baseDirectory + "/${shard}")
); # );
mapAttrs (name: _: baseDirectory + "/${name}/package.nix") (readDir baseDirectory);
in in
# mapAttrs (a: b: builtins.trace (builtins.tryEval a) b) ( # mapAttrs (a: b: builtins.trace (builtins.tryEval a) b) (