From 10e181a89bd58266ad459d21f33bd613e3569851 Mon Sep 17 00:00:00 2001
From: Youwen Wu <youwenw@gmail.com>
Date: Thu, 4 Apr 2024 01:09:08 -0700
Subject: [PATCH] refactor: change popovers in social to be semantically
 correct

---
 src/lib/components/Socials.svelte | 18 ++++++++++++++----
 src/routes/+page.svelte           | 10 +++++-----
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/lib/components/Socials.svelte b/src/lib/components/Socials.svelte
index f8f1b3b..2b7def2 100644
--- a/src/lib/components/Socials.svelte
+++ b/src/lib/components/Socials.svelte
@@ -56,8 +56,13 @@
 		<LinkedinLogo />
 	</Button>
 	<Popover.Root>
-		<Popover.Trigger>
-			<Button class="hover:scale-110 transition-transform" variant="ghost" size="icon">
+		<Popover.Trigger asChild let:builder>
+			<Button
+				class="hover:scale-110 transition-transform"
+				variant="ghost"
+				size="icon"
+				builders={[builder]}
+			>
 				<DiscordLogo />
 			</Button>
 		</Popover.Trigger>
@@ -70,8 +75,13 @@
 		</Popover.Content>
 	</Popover.Root>
 	<Popover.Root>
-		<Popover.Trigger>
-			<Button class="hover:scale-110 transition-transform" variant="ghost" size="icon">
+		<Popover.Trigger asChild let:builder>
+			<Button
+				class="hover:scale-110 transition-transform"
+				variant="ghost"
+				size="icon"
+				builders={[builder]}
+			>
 				<EnvelopeClosed />
 			</Button>
 		</Popover.Trigger>
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index c7c739e..ab9522a 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -22,11 +22,11 @@
 		</Typewriter>
 		<div class="text-2xl md:text-3xl font-medium mt-10 text-center">
 			<Typewriter cursor mode="loop">
-				<p>a student.</p>
-				<p>a programmer.</p>
-				<p>a math enthusiast.</p>
-				<p>a musician.</p>
-				<p>a hacker.</p>
+				<h2>a student.</h2>
+				<h2>a programmer.</h2>
+				<h2>a math enthusiast.</h2>
+				<h2>a musician.</h2>
+				<h2>a hacker.</h2>
 			</Typewriter>
 			<br />
 			<Typewriter mode="scramble" scrambleDuration={1000}>